#25566 closed Bug (fixed)
Admin popup_response.html needs a title
| Reported by: | Ville Skyttä | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
django/contrib/admin/templates/admin/popup_response.html has:
<title></title>
http://html5.validator.nu/ flags an empty title as an error: "Error: Element title must not be empty."
http://www.w3.org/TR/html5/document-metadata.html#the-title-element says that title must be "Text that is not inter-element whitespace." Adding the title would be trivial, but what to put there?
Something generic like {% trans 'Popup closing...' %}?
Change History (5)
comment:1 by , 9 years ago
| Easy pickings: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 9 years ago
| Has patch: | set |
|---|
comment:3 by , 9 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Note:
See TracTickets
for help on using tickets.
Your suggestion seems okay to me.