Move admin changelist filters into a separate class (Mixin)

[Emmanuelle Delescolle]

As suggested by @mjtamlyn at DjangoConEurope, move admin changelist filters into a separate class, so that it is usable both by the admin and CBV's.

I am thinking of creating first 2, then 3 mixins:

• a BaseListFilter mixin holding most of the logic of filtering
• an AdminFilter mixin (extending BaseListFilter) with admin changelist specifics
• finally a FilteredList Mixin (extending BaseListFilter) to use with CBV's

[Merijn Bertels]

Maybe we should make this ticket a subticket of a bigger feature "Give Class Based Views (CBV) more admin functionality" or "Re-use admin code so that users can use it in CBV - like actions, filters or inlines". I think the advance of is this approach is that when we give the class based views (CBV) more functionality, 3th party projects are going to build "better" admin apps and Django can re-use the code to slowly transfer the admin to the new views.

One thing that I all ready found is that ListFilter need a ChangList to render the url for each option. So you can make a ListView that uses a one or more ListFilters in the CBV only when you want to render it you suddenly need a ChangList.

Maybe it's a better idea to start a Group Discussion for this subject.

[Emma Delescolle]

*hides under a rock*

I had absolutely no recollection this ticket had ever been accepted. I'm very glad it was. And now that you have taken it under your wing, I have no intention of stealing your thunder. But if you need help or a review or anything, feel free to ping me here or on github!

[Antoliny]

Replying to Emma Delescolle:

*hides under a rock*

I had absolutely no recollection this ticket had ever been accepted. I'm very glad it was. And now that you have taken it under your wing, I have no intention of stealing your thunder. But if you need help or a review or anything, feel free to ping me here or on github!

Hello Emma Delescolle :)
I am currently working on a similar issue (Issue 36175).
While working on this, I felt that not only Pagination but also Filter should be separated. While searching to see if a similar issue existed, I came across this ticket.

I agree that the ChangeList class has too many responsibilities, and I believe a structural improvement is necessary. However, I think this issue can only proceed successfully after completing the refactoring of Pagination.
(It will probably depend on my skills..)

Thank you for submitting this ticket Emma Delescolle!
I will do my best to improve the Admin page. Since separating Pagination is a similar task, having your review would be incredibly helpful and greatly appreciated 💪

[Emma Delescolle]

I'll give it a look some time tomorrow!