#2489 closed enhancement (fixed)
Make everything Unicode
| Reported by: | Adrian Holovaty | Owned by: | Malcolm Tredinnick |
|---|---|---|---|
| Component: | Core (Other) | Version: | |
| Severity: | normal | Keywords: | unicode-branch |
| Cc: | rushman@…, nesh@…, cw264701@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
At some point, we would like to make Django use Unicode objects everywhere internally, with conversion to/from a specific charset happening on input and output. This ticket is a holding place for all related discussion/links.
UnicodeInDjango is a related wiki page.
A number of tickets have been created (and closed) that related to this problem: #924, #2276, #2132.
Attachments (2)
Change History (18)
comment:1 by , 18 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 18 years ago
by , 18 years ago
| Attachment: | HttpResponse_headers.patch added |
|---|
comment:3 by , 18 years ago
| Summary: | Make everything Unicode → [patch] Make everything Unicode |
|---|
comment:6 by , 18 years ago
| Cc: | added |
|---|
by , 18 years ago
| Attachment: | capfirst.diff added |
|---|
small fix for capfirst filter to enable unicode strings
comment:7 by , 18 years ago
#2376 (only ascii support in initial sql) also closed in favour of this ticket.
comment:8 by , 18 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
In #393, filters are fixed to work with unicode strings (but currently converts objects not type basestring with str() still for now).
comment:9 by , 18 years ago
comment:10 by , 18 years ago
in #3398 the problem was that I didn't use unicode anywhere in my source, so the bug was quite confusing.
comment:11 by , 18 years ago
| Cc: | added; removed |
|---|
comment:12 by , 18 years ago
| Owner: | changed from to |
|---|
Oh God! I just realised this was where elephants (and useful tickets) have come to die. It's very difficult to track all of the tickets that are mentioned here because you have to carefully read every comment to work out if it's a comment about a ticket or a new ticket appearing. Since they're no longer open, it's even harder to track them any other way. It's almost the exact opposite of fun. :-(
Triagers: please do NOT close any more tickets as dupes of this one. If they have Unicode in the title or keywords (or codec or utf8), I'll find them and be able to work through things methodically. So better to put "unicode" in the keywords field.
No need to do anything with the tickets that are mentioned here, though, since I've got them on a list now.
comment:13 by , 17 years ago
| Keywords: | unicode-branch added |
|---|---|
| Summary: | [patch] Make everything Unicode → Make everything Unicode |
Almost of the tickets mentioned here have now been fixed on the unicode branch.
The exceptions are enhancements to slug-generation (#2276, #2716), which has to be done both in Javascript and Python. #2276 is the wrong solution altogether and #2716 is a partial fix that I'll combine with some old Javascript improvements from Bill de hÓra. But that's an enhancement (it's a slug generator, not a transliteration function, after all).
I'll close this ticket once the unicode branch has been merged into trunk.
comment:14 by , 17 years ago
| Cc: | added |
|---|
comment:15 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
After #2514 HttpResponse breaks with headers set from DB. With the following view code
def profile_dl_pgp_key(request, user_id): profile = get_object_or_404(UserProfile, user__pk=user_id) response = HttpResponse(mimetype='text/plain') response['Content-Disposition'] = 'attachment; filename=%s_public_pgp_key.asc' % profile.user.username response.write(profile.public_pgp_key) return responsethis error occurs
Mod_python error: "PythonHandler django.core.handlers.modpython" Traceback (most recent call last): File "/usr/local/lib/python2.4/site-packages/mod_python/apache.py", line 299, in HandlerDispatch result = object(req) File "/usr/local/lib/python2.4/site-packages/django/core/handlers/modpython.py", line 163, in handler return ModPythonHandler()(req) File "/usr/local/lib/python2.4/site-packages/django/core/handlers/modpython.py", line 146, in __call__ populate_apache_request(response, req) File "/usr/local/lib/python2.4/site-packages/django/core/handlers/modpython.py", line 154, in populate_apache_request mod_python_req.headers_out[key] = value TypeError: table values must be stringsKey in mod_python_req.headers_out[key] is a unicode string we got from psycopg2, so it breaks.
As a fix patch below could be used.