Opened 10 years ago

Closed 10 years ago

#24703 closed Cleanup/optimization (fixed)

Use MigrationLoader in squashmigrations

Reported by: Marten Kenbeek Owned by: Marten Kenbeek
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Just a small thing I noticed: squashmigrations creates a MigrationExecutor, but only ever uses the executor.loader attribute. It would be cleaner to directly use a MigrationLoader, same as in makemigrations and showmigrations.

Change History (4)

comment:1 by Marten Kenbeek, 10 years ago

Owner: changed from nobody to Marten Kenbeek
Status: new → assigned

PR: ​https://github.com/django/django/pull/4561

comment:2 by Markus Holtermann, 10 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Markus Holtermann, 10 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Markus Holtermann <info@…>, 10 years ago

Resolution: → fixed
Status: assigned → closed

In 1521861:

Fixed #24703 -- Changed squashmigrations to use a MigrationLoader

Changed squashmigrations to not instantiate a MigrationExecutor,
but to directly use a MigrationLoader instance instead.

Note: See TracTickets for help on using tickets.
Back to Top