Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#24659 closed Cleanup/optimization (fixed)

Docs of backends.smtp.EmailBackend: use_tls default should be False, not None

Reported by: Thomas Güttler Owned by: nobody
Component: Documentation Version: 1.8
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

https://docs.djangoproject.com/en/1.8/topics/email/#smtp-backend

I don't understand why the defaults of the constructor are different from the defaults of the settings:

use_tls=None
use_ssl=None

The defaults of the settings are "False". Which is more intuitive since it is a boolean (AFAIK).

Attachments (1)

24659.diff (1.5 KB ) - added by Tim Graham 10 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 by Tim Graham, 10 years ago

Has patch: set
Triage Stage: UnreviewedAccepted

Does the attached patch clarify how it works?

by Tim Graham, 10 years ago

Attachment: 24659.diff added

comment:2 by Tim Graham <timograham@…>, 10 years ago

Resolution: fixed
Status: newclosed

In ffe83d16:

Fixed #24659 -- Clarified docs of smtp.EmailBackend parameters.

comment:3 by Tim Graham <timograham@…>, 10 years ago

In 43f800a9:

[1.8.x] Fixed #24659 -- Clarified docs of smtp.EmailBackend parameters.

Backport of ffe83d16bd0abfa58e4448cf9d48b52cc43544e9 from master

Note: See TracTickets for help on using tickets.
Back to Top