Opened 10 years ago

Closed 10 years ago

#24388 closed Cleanup/optimization (fixed)

Drop django.utils._os.rmtree_errorhandler

Reported by: Aymeric Augustin Owned by: nobody
Component: Utilities Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When Django was maintained with SVN, collectstatic could copy the .svn directory inside each directory (e.g. when testing use_default_ignore_patterns=False). Removing these directories was a problem on Windows. [d18d37ce] introduced rmtree_errorhandler to solve that problem.

Since we've moved to git, there's a single .git directory at the root of the repository and we don't need that anymore.

[a9a0f0b0] also used rmtree_errorhandler in startproject/startapp. It's a large commit. I couldn't find anything about rmtree_errorhandler in the ticket, in the code or in the tests. I assume it was included for extra safety.

Change History (2)

comment:1 by Tim Graham, 10 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Claude Paroz, 10 years ago

Resolution: → fixed
Status: new → closed

Removal applied in c688460df6239539d2b5a1fc8c51778086fe7c35.

Note: See TracTickets for help on using tickets.
Back to Top