Opened 18 years ago
Closed 17 years ago
#2437 closed enhancement (fixed)
[patch] Quick Copy to pastebin
Reported by: | Owned by: | Erik Karulf | |
---|---|---|---|
Component: | Uncategorized | Version: | dev |
Severity: | normal | Keywords: | pastebin, sprintsept14, sprintdec1 |
Cc: | erik@… | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description
Hi,
I read that there is an "little, easy improvements" open. Since the owner was 'just starting' I tried it myself and thought that it wasn't really difficult to solve.
Regards,
Dirk
Attachments (5)
Change History (21)
by , 18 years ago
Attachment: | debug-pastebin.patch added |
---|
comment:1 by , 18 years ago
Very cool. I think we'll set up a pastebin on djangoproject.com, and point this patch at it, rather than relying on pastebin.com, because pastebin.com has been flaky lately.
comment:2 by , 18 years ago
Summary: | Quick Copy to pastebin → [patch] Quick Copy to pastebin |
---|
comment:3 by , 18 years ago
Its worth noting that the source for pastebin.com is GPL and can be obtained from http://pastebin.com/pastebin.tar.gz, however I suspect any tool used on the djangoproject.com site will be developed with Django :p
comment:4 by , 18 years ago
The pastebin at paste.e-scribe.com is in fact written in Python using Django (source available) and highlights all kinds of Django-related code like Python, Python-Transcripts (interactive Python) and Django-templates. Quite nice.
follow-up: 6 comment:5 by , 18 years ago
Component: | Admin interface → Uncategorized |
---|---|
Keywords: | pastebin added |
Owner: | changed from | to
Triage Stage: | Unreviewed → Accepted |
This has been in the Quick Easy improvements page in the wiki for years.
comment:6 by , 18 years ago
Replying to Simon G. <dev@simon.net.nz>:
This has been in the Quick Easy improvements page in the wiki for years.
And it's on it's way to be "Accepted" for years! :P
If the patch is ok, why isn't it "Ready for checkin" ?
On the other side, I'd rather place a big box telling that pressing the button you're about to publish your traceback on a public site ;)
comment:7 by , 18 years ago
The reason we're waiting on this is because the patch uses pastebin.com, whereas it should use Django's custom pastebin (or maybe dpaste). Django doesn't have a custom pastebin on djangoproject.com, but we might be able to use dpaste.com if Paul B. is willing to commit to maintaining it.
comment:8 by , 18 years ago
Sorry for the lag. Simon G and I have now exchanged email about this -- consider me commited.
by , 18 years ago
Attachment: | django_dpaste.diff added |
---|
comment:9 by , 18 years ago
I've attached a patch which modifies the original from dummy (at) habmalnefrage.de to use dpaste. Note that this also escapes a few other values in debug.py that should be escaped.
@ Paul Bx: I've added a a "source" parameter which you can use to track stats.
comment:10 by , 17 years ago
Keywords: | sprintsept14 added |
---|---|
Triage Stage: | Accepted → Ready for checkin |
comment:11 by , 17 years ago
Patch needs improvement: | set |
---|---|
Triage Stage: | Ready for checkin → Accepted |
I was this close to committing this, but then I tried it out first. Unfortunately, it's not very visually appealing. On Firefox, at least, the button gets a bit lost in amongst all the traceback text.
We also probably need a short (one sentence?) description of what will happen when you push the button. Something like "this will send the traceback to a public website so you can share it with others. You will have a chance to confirm the paste before it is made public" -- but use better wording. I agree with Marc Fargas that some explanation is probably necessary.
However, making it look less crushed together is the real priority here. We always win "prettiest debug page" at the country fair and adding this would hurt our chances. Apart from that, it's good.
comment:12 by , 17 years ago
Cc: | added |
---|---|
Keywords: | sprintnov29 added |
Owner: | changed from | to
Status: | new → assigned |
Assuming Fredrik/Simon doesn't mind, I'll pretty this up at the November 29th sprint.
by , 17 years ago
Attachment: | django_dpaste-2.diff added |
---|
Updated to include some extra environment information
comment:13 by , 17 years ago
Keywords: | sprintdec1 added; sprintnov29 removed |
---|
The patch also removes some extraneous text (per Jacob's recommended)
by , 17 years ago
Attachment: | django-dpaste-prettified.diff added |
---|
comment:14 by , 17 years ago
django-dpaste-prettified.diff is up and it prettifies everything and fixes some usability/extra code bits in the earlier patches.
comment:15 by , 17 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
by , 17 years ago
Attachment: | django-dpaste-prettified-2.diff added |
---|
Updated the prettified code per some recommendations from fellow sprinters
comment:16 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Quick Copy to pastebin