Opened 10 years ago

Closed 10 years ago

#24286 closed Cleanup/optimization (wontfix)

Move django.core.files.locks to django.utils.locks

Reported by: Aymeric Augustin Owned by: Gabriel Muñumel
Component: Utilities Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

It's just a set of utilities and it isn't documented.

Change History (8)

comment:1 by Tim Graham, 10 years ago

Easy pickings: set
Triage Stage: Unreviewed → Accepted
Version: 1.7 → master

My only concern is that django.utils.locks doesn't indicate these are *file* locks.

comment:2 by Gabriel Muñumel, 10 years ago

Owner: changed from nobody to Gabriel Muñumel
Status: new → assigned

comment:3 by Gabriel Muñumel, 10 years ago

Hello. I would like to do this change. What exactly I need to change?

comment:4 by Gabriel Muñumel, 10 years ago

I have an error in the docs validation, any idea?

​https://github.com/django/django/pull/4146

comment:6 by Tim Graham, 10 years ago

I'm less enthusiastic about the idea after seeing django/core/files/move.py which is a file utility that only relies on locks (but documented) and #20488 which adds django/core/files/copy.py which also seems suitable for utils. I guess most of django.core.files could go in utils if we had to do it over again, but not sure there's much benefit in splitting things now. Aymeric, did you have any more motivation than what you stated in the ticket?

comment:7 by Aymeric Augustin, 10 years ago

No. I just filed the ticket as I came across the module and it seemed misplaced. I didn't investigate much.

comment:8 by Tim Graham, 10 years ago

Resolution: → wontfix
Status: assigned → closed
Note: See TracTickets for help on using tickets.
Back to Top