#24179 closed New feature (fixed)
FilteredSelectMultiple widget - add filter field to the right column.
| Reported by: | gdmka | Owned by: | Gav O'Connor |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Normal | Keywords: | FilteredSelectMultiple, filter_horizontal, UI |
| Cc: | gdmka | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | yes |
Description (last modified by )
I found that working with large datasets using filter_horizontal and thus FilteredSelectMultiple widget can be painful if you need to filter out selected entries.
As, the UI is builded dynamically it is pretty easy to achieve the result you see below. I believe this feature is small but important.
I have a patch for that, should i attach it to the ticket or i can simply make a Pull request on Github referring this particular ticket?
Change History (23)
comment:1 by , 10 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 10 years ago
| Cc: | added |
|---|---|
| Easy pickings: | set |
comment:3 by , 10 years ago
| Easy pickings: | unset |
|---|
follow-up: 6 comment:4 by , 10 years ago
Do we save only the values that appear due to the search or do we save all the "hidden" values as well?
Great question!
I believe that filtering out values that do not match search criteria is what should be default upon form submission. So we move the filtered out (hidden) back to the "available" column. The rest of the logic: eg doubleclick on filtered results, stays the same.
comment:5 by , 10 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:6 by , 10 years ago
Replying to gdmka:
Do we save only the values that appear due to the search or do we save all the "hidden" values as well?
Great question!
I believe that filtering out values that do not match search criteria is what should be default upon form submission.
I would expect the opposite since the filter on the left side doesn't work this way.
comment:7 by , 10 years ago
| Component: | Forms → contrib.admin |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Version: | 1.7 → master |
comment:8 by , 8 years ago
| Owner: | changed from to |
|---|
comment:9 by , 8 years ago
| Has patch: | set |
|---|
I have submitted a PR. It's currently for 1.8 version. Please see if the functionality is correct and I will update it for the master branch. Please don't review the code itself. It will need refactoring after the functionality is confirmed.
comment:10 by , 8 years ago
| Patch needs improvement: | set |
|---|
comment:11 by , 3 years ago
| Owner: | removed |
|---|---|
| Status: | assigned → new |
comment:12 by , 2 years ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:13 by , 2 years ago
| Patch needs improvement: | unset |
|---|
PR created to allow the "Selected" column to be filtered in the same was as the "Available" column.
The fix is purely for displaying the results, and the value passed to the server/saved to the DB is not affected by what options are visible due to the search terms.
comment:14 by , 2 years ago
| Needs tests: | set |
|---|
comment:15 by , 2 years ago
| Needs tests: | unset |
|---|
comment:17 by , 2 years ago
| Patch needs improvement: | unset |
|---|
comment:18 by , 2 years ago
| Patch needs improvement: | set |
|---|
comment:19 by , 2 years ago
| Patch needs improvement: | unset |
|---|
comment:20 by , 2 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
The tricky thing I have seen with this type of UI is determining what the proper behavior is when a search term is entered in the right hand search box and the form is saved. Do we save only the values that appear due to the search or do we save all the "hidden" values as well?