Opened 10 years ago
Closed 9 years ago
#24116 closed Cleanup/optimization (fixed)
Refactor AdminSite.check_dependencies with the checks framework
| Reported by: | Aymeric Augustin | Owned by: | Vincenzo Pandolfo |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description (last modified by )
The title says it all.
This ticket should also consider improving or dropping the check for the auth context processor. Currently it's skipped when there isn't exactly one Django templates engine configured in TEMPLATES. This could be improved. It doesn't account for the possibility that a developer will provide their own customized version. This is intractable.
Change History (10)
comment:1 by , 10 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 10 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:3 by , 9 years ago
| Easy pickings: | set |
|---|
comment:4 by , 9 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:5 by , 9 years ago
comment:6 by , 9 years ago
| Has patch: | set |
|---|---|
| Needs documentation: | set |
| Needs tests: | set |
Ideally we could also add some tests for this and documentation in docs/ref/checks.txt.
comment:8 by , 9 years ago
| Needs documentation: | unset |
|---|---|
| Needs tests: | unset |
comment:9 by , 9 years ago
| Patch needs improvement: | set |
|---|
Left a round of review comments. Please uncheck "Patch needs improvement" after it's updated.
comment:10 by , 9 years ago
| Patch needs improvement: | unset |
|---|
Note:
See TracTickets
for help on using tickets.
Another problem from duplicate ticket #25877, "It runs as a side effect of loading the admin URLs. If it must run when Django starts it should be called from
AdminAppConfig.ready()instead."