Python3 AttributeError with redirect_to_login and lazy LOGIN_URL

[Peter Schmidt]

See discussion on #18776 to decide whether to keep patching symptoms or fix the root cause.

Ran into the same AttributeError: '__proxy__' object has no attribute 'decode'.

Please see attached test_redirect_to_login.diff or ​https://github.com/mathspace/django/compare/error-lazylogin-master which passes under Python 2.7 but throws the AttributeError under Python 3.4

One workaround is to explicitly pass the string form of the variable, i.e.

redirect_to_login(next=..., login_url=str(settings.LOGIN_URL))

[Claude Paroz]

Could you elaborate about your fix the root cause idea?

[Peter Schmidt]

Re: 24097_lazy.diff​ please see commit comments on ​https://github.com/mathspace/django/compare/error-lazylogin-master

[Tim Graham]

This doesn't appear to be a regression in master as 1.7 and 1.6 are also affected (seems like a crashing issue worth backporting though).

[Claude Paroz]

I would be tempted to solve the issue in django.shortcuts.resolve_url by expanding the URL to a string when it's a lazy instance. Thoughts?

[Claude Paroz]

Alternate PR: ​https://github.com/django/django/pull/3874

[Peter Schmidt]

Replying to claudep:

Alternate PR: ​https://github.com/django/django/pull/3874

+1 here. This also cleans up the quick fix for #18776 which is good.

My attempt at a patch did feel like I was fighting the Zen of Python by getting too involved with str vs bytes.

Thanks to ​Oktay Sancak for writing the original failing test (albeit under Python2) and ​Alvin Savoy for supporting contributing back to the community.

[Claude Paroz <claude@…>]

In d7bc37d611b43d58be4b430faf0b9813bcde29c6:

Fixed #24097 -- Prevented AttributeError in redirect_to_login

Thanks Peter Schmidt for the report and the initial patch.
Thanks to ​Oktay Sancak for writing the original failing test and
Alvin Savoy for supporting contributing back to the community.

[Claude Paroz <claude@…>]

In 7e65876b7c34d0c43c94ba01543a0050270a34fe:

[1.7.x] Fixed #24097 -- Prevented AttributeError in redirect_to_login

Thanks Peter Schmidt for the report and the initial patch.
Thanks to Oktay Sancak for writing the original failing test and
Alvin Savoy for supporting contributing back to the community.
Backport of d7bc37d61 from master.