Opened 10 years ago
Closed 10 years ago
#24017 closed Bug (fixed)
add python_2_unicode_compatible to classes in db/migrations
| Reported by: | Josh Schneier | Owned by: | Josh Schneier |
|---|---|---|---|
| Component: | Migrations | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | yes | UI/UX: | no |
Description (last modified by )
i was looking into an unrelated issue and noticed that python_2_unicode_compatible wasn't applied to some classes with str db/migrations.
Change History (5)
comment:1 by , 10 years ago
| Description: | modified (diff) |
|---|---|
| Status: | new → assigned |
comment:2 by , 10 years ago
comment:3 by , 10 years ago
| Component: | Uncategorized → Migrations |
|---|---|
| Needs tests: | set |
| Triage Stage: | Unreviewed → Accepted |
| Type: | Uncategorized → Bug |
comment:4 by , 10 years ago
| Needs tests: | unset |
|---|---|
| Patch needs improvement: | set |
Apart from the few comments and annotations I left on the pull request, this looks ready-for-checkin.
comment:5 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
I've created a pull request here: https://github.com/django/django/pull/3750
Let me know if I've done anything wrong, I've never contributed to django before and was trying to follow the project/contributor guidelines. I don't think this particular change needs tests and am not sure if it needs a documentation update.