Opened 10 years ago

Closed 8 years ago

#23905 closed Cleanup/optimization (fixed)

Use built-in email.utils.make_msgid() when dropping Python 2

Reported by: Tim Graham Owned by: nobody
Component: Core (Mail) Version: dev
Severity: Normal Keywords: drop-py2
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

django.core.mail.message.make_msgid() can be replaced with the Python built-in version when we drop Python 2. In Python 3.2 the domain parameter was added which is needed to accomplish the fqdn caching we are doing.

Change History (3)

comment:1 by Tim Graham <timograham@…>, 10 years ago

In ebb927c4c997d4c8d9a55ec78cd2476a13bd1782:

Removed workaround for lack of os.getpid() in Jython.

The Jython bug was fixed in ​http://bugs.jython.org/issue1518
(tested on Jython 2.7b3); also updated make_msgid() to be more like
the version in Python 3.2+; refs #23905.

Thanks Simon Charette for testing and review.

comment:2 by Tim Graham, 8 years ago

Has patch: set
Triage Stage: Someday/Maybe → Accepted

​PR

comment:3 by GitHub <noreply@…>, 8 years ago

Resolution: → fixed
Status: new → closed

In 9e917cc2:

Fixed #23905, refs #23919 -- Used make_msgid() from stdlib.

Note: See TracTickets for help on using tickets.
Back to Top