#23898 closed Bug (fixed)
django.contrib.admin.actions.delete_selected missing admin_site.each_context
| Reported by: | Redouane Zait | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Normal | Keywords: | delete_selected action, each_context, site_title, site_header, site_url |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
Hello,
in django's delete_selected action (django.contrib.admin.actions.delete_selected)
the templates are rendered without admin_site's each_context, and thus
it always renders the default values for admin_site.each_context() key attributes (site_title, site_header, site_url)
So if you override/use custom values for site_title, site_header, site_url they will not be used on the delete_selected action view.
Change History (7)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
| Version: | 1.7 → master |
|---|
comment:3 by , 10 years ago
| Has patch: | set |
|---|---|
| Needs tests: | set |
| Patch needs improvement: | set |
| Triage Stage: | Unreviewed → Accepted |
Hi,
The pull request looks good but it's missing some tests.
Thanks!
comment:4 by , 10 years ago
Can you use the same style as other views in django/contrib/admin/options.py?
While you're there it would be nice to support extra_context too (#12044).
comment:5 by , 10 years ago
| Needs tests: | unset |
|---|---|
| Patch needs improvement: | unset |
| Triage Stage: | Accepted → Ready for checkin |
comment:6 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
pull request sent.
https://github.com/django/django/pull/3607