[patch] delete multiple items at once

[jay@…]

In response to ​http://www2.jeffcroft.com/2006/jul/20/top-ten-things-suck-about-django/ #3 Admin interface: inability to delete multiple items at once.

I came up with this patch because I had the same need. I had a few thoughts of how to implement this, but I went with this way because it seemed to follow the way the Django admin works.

Feedback is appreciated.

[atlithorn]

I guess you need to attach delete.js as well for the patch to work? I wrote a patch for this a couple of weeks ago as well but I don't want to make this more difficult than necessary, if yours works then we'll just dump ours for yours.

[jay@…]

I updated this patch to work with people who are superusers. Before only people that had explicit permisions got the delete box.

Also Trac would not let me override the diff file, so I renamed it new_multi_delete.diff

Jay Graves

[jay@…]

updating the version

[atlithorn]

Looks good, I would like to see the deletion go through an "Are you sure" step just like the normal delete_stage process. Also I was unable to delete objects that had primary keys based on something other than the auto_increment id. I'm including a patch based on your patch.

It needs the accompanying deletelist_confirmation.html.
I also replaced the need for delete.js with the following change to the delete anchor:
... onclick="document.getElementById('delete_form_checked').submit()"

[atlithorn]

updated patch, based on jay's patch

[atlithorn]

template to allow for confirmation of deletion

[deryck <deryck@…>]

I'm interested in this functionality, too. Though, there are a couple things about the patches.

User's "has_delete_permissions" wasn't being set correctly. The patch I'm including fixes this. Also, I think this should be done by a regular form POST, not with the JavaScript onsubmit handler. The updated patch does this now.

Some warts still: Using the form submit, the "Delete checked" button falls at the bottom of the page, which on long pages may not be good. Maybe this doesn't matter. Also, I'm not sure if the "Delete?" check box should appear on every object's list page. Maybe this should be an Admin option on the model, and then, if permissions are present, the functionality appears.

Also, the patch I'm attaching includes the template changes inline with the rest of the code.

[deryck <deryck@…>]

New patch, fixing "has_delete_permissions" and doing a proper form POST submit (sans JavaScript)

[Chris Beaven]

Looks really good! There's still some decisions to make but I'm pretty sure this will get accepted. Good work Jay, atlithorn and deryck.

[Øyvind Saltvik <oyvind@…>]

Closed as wontfix, repoen if patch works against newforms-admin.

[James Bennett]

Please don't do that; feature requests that are worth considering for newforms-admin should remain open until newforms-admin is done.

[Jacob]

At some point in the future we're going to revisit the design/behavior of the admin, and this will certainly be part of that process. However, we're not in a hurry to add bits on piecemeal since that could lead to crufty UI.

[Bryan Veloso]

​http://code.google.com/p/django-batchadmin/

Just adding this here since it is definitely relevant and nicely designed.

[Eric Holscher]

Fixed in r10121, allowing bulk actions in the admin.