Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#23799 closed Bug (fixed)

squashmigrations --no-optimize still optimizes

Reported by: Tillmann Karras Owned by: Tillmann Karras
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: info+coding@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Tillmann Karras)

The --no-optimize option doesn't have any effect.

See pull request 3500.

Change History (13)

comment:1 by Tillmann Karras, 10 years ago

Description: modified (diff)

See ​https://github.com/django/django/pull/3500

comment:2 by Markus Holtermann, 10 years ago

Cc: info+coding@… added

comment:3 by Markus Holtermann, 10 years ago

Needs tests: set

Though its a rather small patch I'd like to see a test for the now working feature.

comment:4 by Tim Graham, 10 years ago

Triage Stage: Unreviewed → Accepted

comment:5 by Deni Bertovic, 10 years ago

Owner: changed from nobody to Deni Bertovic
Status: new → assigned

comment:6 by avojnovicDk, 10 years ago

Owner: changed from Deni Bertovic to avojnovicDk

comment:7 by Tillmann Karras, 10 years ago

@avojnovicDk: Are you at DjangoUnderTheHood? I forgot to set the owner, now we might be working on the same thing.

comment:8 by Yamila, 10 years ago

Needs tests: unset

there is PR

​https://github.com/django/django/pull/3521

we didn't see this thread updated till the login... I made the PR without knowing...

comment:9 by Tillmann Karras, 10 years ago

Owner: changed from avojnovicDk to Tillmann Karras

After talking with yamila-moreno, we agreed to have me finish this ticket. Sorry avojnovicDk, haven't heard anything from you, so I'll just change the owner (again).

comment:10 by avojnovicDk, 10 years ago

I just saw this. :) Yes, I am at DjangoUnderTheHood and was just working on this. I'll find something else to work on, no problem. It's great that the ticket is finished.

comment:11 by Markus Holtermann, 10 years ago

Triage Stage: Accepted → Ready for checkin

comment:12 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: assigned → closed

In d18810131995dac63f9d89b0beaeadfc935130aa:

Fixed #23799 -- Made makemigrations respect --no-optimize.

Thanks to yamila-moreno for the idea of a skip message.

comment:13 by Tim Graham <timograham@…>, 10 years ago

In dfcac7d7f5f1f108ae2c561f0f755f08d75a1c27:

[1.7.x] Fixed #23799 -- Made makemigrations respect --no-optimize.

Thanks to yamila-moreno for the idea of a skip message.

Backport of d18810131995dac63f9d89b0beaeadfc935130aa from master

Note: See TracTickets for help on using tickets.
Back to Top