#23705 closed Cleanup/optimization (fixed)
mod_wsgi deployment documentation includes unncessary AliasMatch
Reported by: | Keryn Knight | Owned by: | Tim Graham |
---|---|---|---|
Component: | Documentation | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | django@… | Triage Stage: | Ready for checkin |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
This line in the docs appears to be a remnant of the time before staticfiles:
AliasMatch ^/([^/]*\.css) /path/to/mysite.com/static/styles/$1
which as far as I understand it, is to allow domain-root-relative CSS files to be point through to staticfiles collectstatic
output.
Off the top of my head, this seems like it would sidestep using {% static "file.css" %}
(which would still work) and is not required in any sane/tidy configuration [and probably makes it harder to load those files in the dev server by virtue of needing another urlconf pattern].
It additionally has the burden of implying that static/styles
exists, or is the only place CSS files could reside [the static/styles
path is *only* mentioned in that AliasMatch]
It looks like the commit that introduced it was 9fd19c01611e5ed1ed64bbeb462ab96499d72a6c, in the 1.1 days. Two tickets have existed: #13912 and #11229, also both back in the pre-staticfiles days. It appears to have just been carried forward across renames accidentally, IMHO, and I can't think of a great reason for it being there.
Change History (4)
comment:1 by , 10 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Triage Stage: | Unreviewed → Ready for checkin |
comment:2 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
In 4b0a45ce64bfa1ce39d963738ffb0af57f4517e5: