Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#23695 closed Bug (fixed)

django.views.decorators.http.condition decorator, HEAD request without etag

Reported by: Anton Novosyolov Owned by: nobody
Component: HTTP handling Version: 1.7
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

If ETag is not used, only If-Modified-Since, and request method is HEAD then 200 is returned instead of "304 Not Modified".

Some sites for checking 304 status (e.g. ​http://last-modified.com/en/ ) use HEAD for checking.

Change History (4)

comment:1 by Anton Novosyolov, 10 years ago

Created pull request ​https://github.com/django/django/pull/3396

comment:2 by Collin Anderson, 10 years ago

Component: Uncategorized → HTTP handling

comment:3 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In 9f1202c166093160c8796dc570d675415fdf5bf8:

Fixed #23695 -- Made condition decorator work for HEAD requests without ETag.

comment:4 by Collin Anderson, 10 years ago

Triage Stage: Unreviewed → Accepted

I meant to accept this earlier :). Thanks Tim.

Note: See TracTickets for help on using tickets.
Back to Top