System check framework runs multiple times

[Loic Bistuer]

Every time a command calls call_command() without skip_checks=True, system checks run multiple times.

flush:
​https://github.com/django/django/blob/c974b7bbe0abddd9796c65a23b68e61ba75cb5a3/django/core/management/commands/flush.py#L89

testserver:
​https://github.com/django/django/blob/c974b7bbe0abddd9796c65a23b68e61ba75cb5a3/django/core/management/commands/testserver.py#L30
​https://github.com/django/django/blob/c974b7bbe0abddd9796c65a23b68e61ba75cb5a3/django/core/management/commands/testserver.py#L40

This is similar to #23650 which addressed the issue for migrate.

[Claude Paroz]

Should we systematically set skip_checks to True in call_command? I think that we can legitimately assume that when a management command is called through call_command, either the checks have already passed... or it is too late!

[Loic Bistuer]

+1 for making skip_checks=True the default for call_command.

[Claude Paroz]

​https://github.com/django/django/pull/3393

[Claude Paroz <claude@…>]

In 685edab9da89b54e3e0e7bbc1c9f8b33d3f45969:

Fixed #23685 -- Made call_command skip checks by default

Thanks Loic Bistuer for the report/review and Tim Graham for the
review.

[Claude Paroz <claude@…>]

In bbc3505ef81768aa2afac8f73e6d45b5e8000c55:

Removed unneeded override_system_checks

Refs #23685.

[Ilya Baryshev]

Thnx for a fix.
Will this be backported to 1.7.X or should I use master branch?

[Claude Paroz]

We don't plan to backport this on 1.7.x because it didn't seem to be a blocker/crasher, but more an annoyance. If you have a use case where this is a more serious problem, we could reconsider.