Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#23539 closed Bug (fixed)

GenericInlineModelAdmin doesn't utilize get_extra (and get_max_num/get_min_num)

Reported by: Justin Caratzas Owned by: nobody
Component: contrib.contenttypes Version: 1.7
Severity: Normal Keywords:
Cc: bigjust@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Justin Caratzas)

the helper functions get_extra, get_max_num, and get_min_num were introduced in 1.6 as a way of calculating extra, max_num, min_num per request. The GenericInlineModelAdmin has continued using the old self.extra, max_num, and min_num values.

Change History (7)

comment:1 by Justin Caratzas, 10 years ago

Cc: bigjust@… added
Component: Uncategorized → contrib.contenttypes

comment:2 by Justin Caratzas, 10 years ago

Description: modified (diff)
Has patch: set

PR submitted ​https://github.com/django/django/pull/3263

comment:3 by Simon Charette, 10 years ago

Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Bug

comment:4 by Tim Graham, 10 years ago

Needs tests: set

Please uncheck "Needs tests" when they are added, thanks.

comment:5 by Justin Caratzas, 10 years ago

Needs tests: unset

comment:6 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In cf43a1ee909ab5dbca5b6a40247cd093a3e2ac8d:

Fixed #23539 -- Added get_extra(), get_max_num(), and get_min_num() hooks to GenericInlineModelAdmin.

comment:7 by Tim Graham <timograham@…>, 10 years ago

In cc74d8e02e8b659b914859d60002aaa47600f0ff:

[1.7.x] Fixed #23539 -- Added get_extra(), get_max_num(), and get_min_num() hooks to GenericInlineModelAdmin.

Backport of cf43a1ee90 from master

Note: See TracTickets for help on using tickets.
Back to Top