Opened 10 years ago

Closed 10 years ago

#23303 closed Cleanup/optimization (fixed)

sqlmigrate doesn't output BEGIN and COMMIT statements

Reported by: Baptiste Mispelon Owned by: nobody
Component: Core (Management commands) Version: 1.7-rc-2
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

All other sql* commands wrap their output in BEGIN; ... COMMIT; statements.

PR here: ​https://github.com/django/django/pull/3076

Change History (9)

comment:1 by Tim Graham, 10 years ago

Has patch: set
Patch needs improvement: set
Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted
Version: 1.7-beta-2 → 1.7-rc-2

comment:2 by Tim Graham, 10 years ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:3 by Baptiste Mispelon <bmispelon@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In 5853c87a458f62ebd62d7809168355610de2570c:

Fixed #23303 -- Added BEGIN and COMMIT statements to the output of sqlmigrate.

comment:4 by Baptiste Mispelon <bmispelon@…>, 10 years ago

In 3a80189479a29220bac6d205a1b97184bd76a876:

[1.7.x] Fixed #23303 -- Added BEGIN and COMMIT statements to the output of sqlmigrate.

Backport of 5853c87a458f62ebd62d7809168355610de2570c from master.

Conflicts:

django/core/management/commands/sqlmigrate.py
tests/user_commands/tests.py

comment:5 by Tim Graham, 10 years ago

Resolution: fixed
Status: closed → new

One minor issue with the tests: Oracle doesn't include BEGIN; in its transactions.

comment:6 by Baptiste Mispelon <bmispelon@…>, 10 years ago

In 54164b814cab71a8a0503743befbdcc99ae6c7a0:

Fixed broken tests on Oracle after 5853c87a458f62ebd62d7809168355610de2570c.

Oracle doesn't have a BEGIN statement so the test would
fail.

Refs #23303

comment:7 by Baptiste Mispelon <bmispelon@…>, 10 years ago

In 24d9aee1880ced5892af42f35539a5d705adf512:

[1.7.x] Fixed broken tests on Oracle after 5853c87a458f62ebd62d7809168355610de2570c.

Oracle doesn't have a BEGIN statement so the test would
fail.

Refs #23303

Backport of 54164b814cab71a8a0503743befbdcc99ae6c7a0 from master.

comment:8 by Andrew Godwin, 10 years ago

Why is this reopened? It looks like the other DBs will still get BEGIN/END

comment:9 by Baptiste Mispelon, 10 years ago

Resolution: → fixed
Status: new → closed

Sorry, I forgot to close it again after 54164b814cab71a8a0503743befbdcc99ae6c7a0.

Note: See TracTickets for help on using tickets.
Back to Top