Document change in manage.py sql* --database behavior in 1.7

[manuel.gysin@…]

Hello,

If you set DATABASE_ROUTERS in settings.py, none of the sql-management commands are working:

[root@dgweb Demo]# python manage.py sqlall SampleModel
[root@dgweb Demo]#
[root@dgweb Demo]# python manage.py sql SampleMode
[root@dgweb Demo]#

As soon DATABASE_ROUTERS is removed, things start working again:

[root@dgweb Demo]# python manage.py sqlall SampleModel
BEGIN;
CREATE TABLE "SampleModel_location" (
    "id" integer NOT NULL PRIMARY KEY AUTOINCREMENT,
    "name" varchar(50) NOT NULL
)
;

COMMIT;

[Claude Paroz]

I guess this might be related to the content of your DATABASE_ROUTERS setting. The best way to prove us the presence of a bug would be to provide a sample project where this can be reproduced.

[manuel.gysin@…]

SampleDemo

[anonymous]

Hello

No it have nothing to do with the setting itself.
There is a different behavior between Django 1.6 and 1.7.

This gives no output, because SampleModel in the second_db.

[mgysin@localhost Demo]$ python manage.py sqlall SampleModel
[mgysin@localhost Demo]$

Adjusting the command with --database argument, get things working again:

[mgysin@localhost Demo]$ python manage.py sqlall SampleModel --database=second_db
BEGIN;
CREATE TABLE "SampleModel_location" (
    "id" integer NOT NULL PRIMARY KEY AUTOINCREMENT,
    "name" varchar(50) NOT NULL
)
;

COMMIT;

I'm not sure if this is a design decision or just some side effect with Django 1.7.
But it is very confusing if you are not aware of that. Maybe something like 'Only models in the default database are used, for other databases please provide --database argument' should be printed?

I've added an demo sample with this behavior.

[Areski Belaid]

It's definitely a change of behaviour in Django 1.7.

In 1.7 we read the models from router.get_migratable_models:

​https://github.com/django/django/blob/master/django/core/management/sql.py#L45

in 1.6 we read the models from models.get_models:

​https://github.com/django/django/blob/1.6.5/django/core/management/sql.py

I'm not sure what's the desired implementation for 1.7

[Tim Graham]

The new behavior makes sense to me. I think we should clarify the documentation and add a note about it in the 1.7 release notes.

[Gabriel Muñumel]

Here is the pull request: ​https://github.com/django/django/pull/2988

[Tim Graham]

Don't forget to check the "Has patch" flag so the ticket appears in the review queue. I'll review and commit this now. Thanks.

[Tim Graham <timograham@…>]

In 2077bbe3fefb58eadfde0f2f36af13a0f1d3704a:

[1.7.x] Fixed #23102 -- Documented that sql* commands now respect allow_migrate().

Backport of 0af593dbe5 from master