[patch] Some shortcomings of the PhoneNumberField

[anjohnson@…]

The PhoneNumberField type is not terribly useful as shipped:

• It really should be called USPhoneNumberField since it won't accept international numbers, and outside of the US where numbers are 10 digits long they don't necessarily group them 3+3+4
• The underlying database field stores 20 characters, but the admin web interface only lets me type in 12 (which admittedly is all the validator will currently accept anyhow)
• The validator only accepts numbers in the exact form xxx-xxx-xxxx whereas other formats and separators are as common or more so in general use: (nnn) nnn-nnnn or 1-800-BISNESS are the main examples that come to mind.

I can't fix the first problem -- creating code that will recognize all national phone number formats is not really feasible, and I'm assuming that renaming the field type is also probably not possible at this stage. However I do have a short patch I will attach to this ticket that fixes the other two issues:

• Increases the length and maxlength of the form fields to the size of the underlying database
• Permit additional number formats to be entered such as the ones shown above.

Hope it's useful,

• Andrew

[anjohnson@…]

Patch to fix the shortcomings discussed in ticket.

[anjohnson@…]

Omitted [patch] from the ticket title...

[anonymous]

I agree. phone_re should be something like this to check for international numbers.

phone_re = re.compile(r'^{\d?\d?\d?-?[A-PR-Y0-9]{3}-[A-PR-Y0-9]{3}-[A-PR-Y0-9]{4}$', re.IGNORECASE)}

[serbaut@…]

I agree. However in europe we often use formats like +46 12 34 56 78 so please take this into account.

[Wiliam Alves de Souza <wiliamsouza83@…>]

Other solution

[Wiliam Alves de Souza <wiliamsouza83@…>]

Regular expression for national telephone numbers. Put it in .../django/core/

[Russell Keith-Magee]

The contrib.localflavor app is designed to handle this sort of issue.