Context Navigation

← Previous Ticket
Next Ticket →

#22998 closed Bug (fixed)

GenericRelation cascade deletion doesn't fire pre_delete signals

Reported by:	gwahl@…	Owned by:	nobody
Component:	Database layer (models, ORM)	Version:	1.6
Severity:	Release blocker	Keywords:
Cc:		Triage Stage:	Accepted
Has patch:	yes	Needs documentation:	no
Needs tests:	no	Patch needs improvement:	no
Easy pickings:	no	UI/UX:	no

Description

I have three models:

Node (gfk to)-> Content (fk to)-> Related

Deleting a Related cascades to delete the Content which cascades to delete the Node (because Content has a GenericRelation). This is the expected behavior. However, in Django 1.5 pre_delete would be trigger on Node before deleting it. In 1.6, this is no longer the case.

I've written a test case here: https://github.com/fusionbox/django/tree/generic_relation_cascade_signal. The test passes on 1.5 and fails on 1.6, 1.7, and master.

This is a regression introduced in 97774429aeb54df4c09895c07cd1b09e70201f7d for #19385.

This may be related to #22594 -- both involve fast_delete incorrectly returning True.

Change History (8)

comment:1 by gwahl@…, 10 years ago

Has patch:	set

Uploaded a patch to that branch. I'm not really sure if the logic is correct, but all the tests pass.

comment:2 by Tim Graham, 10 years ago

Component:	Uncategorized → Database layer (models, ORM)
Severity:	Normal → Release blocker
Triage Stage:	Unreviewed → Accepted

Qualifies for a backport to 1.6 since it's a regression from 1.5.

comment:3 by Anssi Kääriäinen, 10 years ago

The code changes look good to me.

If you want to work on this: the tests should be included in generic_relations_regress test module. Also, rename test_it() to test_ticket_22998 for example. After this create a pull request.

I think we want to get this fixed for next RC of 1.7 which will hopefully be released later this week. If you don't have time to work on this in the next couple of days, please inform us as soon as possible.