Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#22801 closed Uncategorized (fixed)

Broken link on Django settings page

Reported by: amkeller@… Owned by: Maxime Turcotte
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Broken link on Django settings page https://docs.djangoproject.com/en/1.4/topics/settings/.

The last 4 words in the sentence "Note that the settings module should be on the Python import search path" are linked to the following page:

http://diveintopython.net/getting_to_know_python/everything_is_an_object.html

This link doesn't work and takes you to the diveintopython.net home page.

The correct link has a "www" prepended to the domain name:

http://www.diveintopython.net/getting_to_know_python/everything_is_an_object.html

I noticed this when the link to the same page on Stack Overflow worked but yous didn't. Stack overflow page with working link: http://stackoverflow.com/questions/865911/is-everything-an-object-in-python-like-ruby

Another question: is this even the right link from that text?

Change History (7)

comment:1 by Baptiste Mispelon, 10 years ago

Easy pickings: set
Triage Stage: UnreviewedAccepted

Hi,

It seems that the redirection in place on diveintopython.net (redirecting diveintopython.net to www.diveintopython.net) is broken and drops the whole path from the URL.

That's probably something which should be reported to them, but in the meantime, it should be enough for us to add the www. to all links pointing there in our documentation (there are a few which you can find by doing git grep diveintopython.net).

As for whether this is the correct link to point to, I believe it is: that section explains what the import search path is.

Thanks.

comment:2 by Maxime Turcotte, 10 years ago

Owner: changed from nobody to Maxime Turcotte
Status: newassigned

comment:3 by Maxime Turcotte, 10 years ago

Has patch: set

Here's my PR

comment:4 by Maxime Turcotte, 10 years ago

Version: 1.6master

Here's the right PR

I'm not sure I'm allowed to do that, but I changed the version to master, but it should be backported to other versions.

comment:5 by Tim Graham <timograham@…>, 10 years ago

Resolution: fixed
Status: assignedclosed

In f97c53c0989336563c535c9737dff197b403054d:

Fixed #22801 -- Added 'www.' to diveintopython.net links

comment:6 by Tim Graham <timograham@…>, 10 years ago

In de0e285be80e0ca756088a97335d8faa698fbe6b:

[1.7.x] Fixed #22801 -- Added 'www.' to diveintopython.net links

Backport of f97c53c098 from master

comment:7 by Tim Graham <timograham@…>, 10 years ago

In fcd2e06ae5110fe6327128e8d170302c20077988:

[1.6.x] Fixed #22801 -- Added 'www.' to diveintopython.net links

Backport of f97c53c098 from master

Note: See TracTickets for help on using tickets.
Back to Top