tempfile.SpooledTemporaryFile passed to File causes exception

[hrlawrenz@…]

When a File object is created from a tempfile.SpooledTemporaryFile, an exception occurs when the File.size method is called and the tempfile.SpooledTemporaryFile isn't large enough to have been written to disk. The exception is caused by an attempt to call os.path.exists on a None value. The name attribute of the tempfile.SpooledTemporaryFile in this case is None in this case because it doesn't exist on disk.

Patch in pull request at ​https://github.com/django/django/pull/2455

The patch just adds another condition before calling os.path.exists to verify that the file name isn't None.

Traceback (most recent call last):

File "/Users/hrwl/Documents/Projects/django/tests/files/tests.py", line 215, in test_in_memory_spooled_temp

self.assertTrue(django_file.size, 17)

File "/Users/hrwl/Documents/Projects/django/django/core/files/base.py", line 43, in _get_size

elif hasattr(self.file, 'name') and os.path.exists(self.file.name):

File "/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/genericpath.py", line 18, in exists

os.stat(path)

TypeError: coercing to Unicode: need string or buffer, NoneType found

[Baptiste Mispelon]

Hi,

There's some trailing whitespace and the added test doesn't work on Python3.

Looks good otherwise.

[Baptiste Mispelon <bmispelon@…>]

In 918a16bc4c099ab0cae72a231de3e99e2a9d02cb:

Fixed #22307 -- Fixed SpooledTemporaryFile bug in File class.

Added condition to prevent checking the existence of a file name of a
file like object when the name attribute is None. This is necessary
because a SpooledTemporaryFile won't exist on the file system or have a
name until it has reached its max_size. Also added tests.

[Aymeric Augustin]

This commit causes a test failure under Python 3:

​http://ci.djangoproject.com/job/Django/database=sqlite3,python=python3.2/4220/testReport/junit/files.tests/SpooledTempTests/test_written_spooled_temp/

[Aymeric Augustin]

Baptiste, can you review and merge ​https://github.com/django/django/pull/2459?

[Baptiste Mispelon <bmispelon@…>]

In 96fc3908ad25f40b4c6e2f76be2639f665223227:

Fixed a failing test introduced in 918a16bc4c099ab0cae72a231de3e99e2a9d02cb.

Refs #22307.

[Baptiste Mispelon]

That fixed it.

Thanks for the heads up.