Sqlite3 backend fails during _remake_table with column named "order"

[netwamp@…]

It seems that column names should be quoted, cause if I try migrate my app, migration fails on following sql request:

INSERT INTO "services_group__new" (description, order, id, slug, title) SELECT description, order, id, slug, title FROM "services_group"

If I try it in db shell, it fails too, as expected.
Message is "Error: near "order": syntax error"

Adding quotes around column names in django.db.backends.sqlite3.schema.DatabaseSchemaEditor._remake_table fixes the problem for me:

django/db/backends/sqlite3/schema.py

@@ -83 +83 @@
         field_maps = list(mapping.items())
         self.execute("INSERT INTO %s (%s) SELECT %s FROM %s" % (
             self.quote_name(temp_model._meta.db_table),
-            ', '.join(x for x, y in field_maps),
-            ', '.join(y for x, y in field_maps),
+            ', '.join(self.quote_name(x) for x, y in field_maps),
+            ', '.join(self.quote_name(y) for x, y in field_maps),
             self.quote_name(model._meta.db_table),
         ))
         # Delete the old table

[Baptiste Mispelon]

Hi,

I can reproduce the issue by doing the following:

1) Create a model with a field called order.
2) Run makemigrations. This creates a first migration file.
3) Add another field to the model created in 1)
4) Run makemigrations again. This creates a second migration file.
5) Attempt to run migrate. This fails with the reported error.

Your proposed fix looks sensible and it works for the reported issue but a full patch should have some tests too.

Thanks.

[Baptiste Mispelon]

Tentative pull request (with tests) here: ​https://github.com/django/django/pull/2378

Reviews welcome.

[Baptiste Mispelon <bmispelon@…>]

In c679cb7f600b13646a1a2b5fc8a03dfcc2e413f2:

Fixed #22168 -- Fixed migrations failing on sqlite when column names are SQL keywords

Thanks to trac user fallen_flint for the report and initial patch.