#21942 closed Cleanup/optimization (fixed)
document Form.clean() in "Forms API" docs
Reported by: | Chris Jerdonek | Owned by: | lkitchner |
---|---|---|---|
Component: | Documentation | Version: | 1.6 |
Severity: | Normal | Keywords: | forms, clean, validation |
Cc: | chris.jerdonek@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | yes | UI/UX: | no |
Description
Currently, the "Forms API" section of the Django docs (and in particular the Using forms to validate data section of that page), does not document Form.clean()
, though the Form.add_error()
documentation in that page references it.
There is some documentation about Form.clean()
in the Form and field validation page, so perhaps the Forms API docs can link there for its information (and/or vice versa).
Change History (11)
comment:1 by , 11 years ago
Cc: | added |
---|
comment:2 by , 11 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 11 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:4 by , 11 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
I have submitted this fix to the GitHub repo. HTML generated with no errors on Ubuntu.
comment:5 by , 11 years ago
Triage Stage: | Ready for checkin → Accepted |
---|
The "ready for checkin" status is for when your patch has been reviewed and is ready to be checked in (see relevant documentation [1]).
I cannot see your fix anywhere: did you submit it as a pull request?
When you have a pull request, please put the link as a comment on this ticket as check the "has patch" checkbox.
Thanks.
[1] https://docs.djangoproject.com/en/1.6/internals/contributing/triaging-tickets/#triage-stages
comment:6 by , 11 years ago
Has patch: | set |
---|
Here is the pull request: https://github.com/django/django/pull/2318
comment:8 by , 11 years ago
I've made the discussed changes from pull 2318 and have made a new pull request.
https://github.com/django/django/pull/2334
comment:9 by , 11 years ago
I made a suggestion on the first pull request that doesn't seem to be reflected in the second one (nor was there a response): https://github.com/django/django/pull/2318#discussion_r9840517
comment:10 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Yes, I would add it under "Using forms to validate data" and move "
.. method:: django.forms.Form.clean()
" from the "Cleaning and validating fields that depend on each other" section ofref/forms/validation.txt
, but then link to that section from the new text in the API doc.