Opened 11 years ago
Closed 11 years ago
#21866 closed Bug (fixed)
Static word "COMMIT"
| Reported by: | Wojciech Banaś | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Management commands) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Wojciech Banaś | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | yes | UI/UX: | no |
Description
In the file "django/core/managment/base.py" is:
self.stdout.write('\n' + self.style.SQL_KEYWORD("COMMIT;"))
and should be:
self.stdout.write(self.style.SQL_KEYWORD(connection.ops.end_transaction_sql()))
Change History (3)
comment:1 by , 11 years ago
| Cc: | added |
|---|---|
| Easy pickings: | set |
| Has patch: | set |
comment:2 by , 11 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Version: | 1.6 → master |
As I commented on the PR, it should be against master, not 1.6.x and you should following the commit message guidelines so the ticket will automatically be closed when the patch is merged. Thanks!
comment:3 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Pull request:
https://github.com/django/django/pull/2208