Opened 11 years ago

Closed 11 years ago

#21717 closed Cleanup/optimization (fixed)

Consider renaming AppConfig.setup(), for instance to startup()

Reported by: Aymeric Augustin Owned by: nobody
Component: Core (Other) Version: dev
Severity: Release blocker Keywords: app-loading
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Quoting Jannis:

The “setup” method of the AppConfig class is actually not setting anything up by default but is an extension point for *additional* code to be run next to the usual “setup code”. That’s an important distinction we must make sure to make clear before launching this API to the community. That’s why I liked “startup” so much because it explains the purpose of the mechanism without assuming that it’s somewhat used to take part of the creation of AppConfig or apps or whatever.

Change History (1)

comment:1 by Aymeric Augustin <aymeric.augustin@…>, 11 years ago

Resolution: → fixed
Status: new → closed

In 1d23d766ab85301eb527629400933fd601355f1a:

Renamed AppConfig.setup to ready.

Thanks Jannis and Marc for the feedback.

Fixed #21717.

Note: See TracTickets for help on using tickets.
Back to Top