Opened 11 years ago

Closed 11 years ago

#21714 closed Cleanup/optimization (fixed)

Move LazySettings._configure_logging to django.setup

Reported by: Aymeric Augustin Owned by: Claude Paroz
Component: Core (Other) Version: dev
Severity: Normal Keywords: app-loading
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Since Django now has an explicit entrypoint, there's no reason to handle logging in the settings anymore.

Change History (7)

comment:1 by Marc Tamlyn, 11 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Claude Paroz, 11 years ago

Owner: changed from nobody to Claude Paroz
Status: new → assigned

comment:4 by Aymeric Augustin, 11 years ago

Could you define configure_logging in another module, for example in django.utils.logging?

django.__init__ should only put the pieces together.

comment:5 by Claude Paroz, 11 years ago

PR updated.

comment:6 by Aymeric Augustin, 11 years ago

Triage Stage: Accepted → Ready for checkin

LGTM

comment:7 by Claude Paroz <claude@…>, 11 years ago

Resolution: → fixed
Status: assigned → closed

In b8e3373f458aa363d59c61b58be390a5a1156467:

Fixed #21714 -- Moved logging configuration to global setup()

Thanks Aymeric Augustin for the report and the review.

Note: See TracTickets for help on using tickets.
Back to Top