Admin templates use a `bodyclass` block without ever calling super.

[Keryn Knight <django@…>]

A reasonable expectation is, I think, to be able to subsume the admin/base_site.html template to do a few tweaks for display purposes, by throwing it in an earlier INSTALLED_APP or into one of the paths set in TEMPLATE_DIRS; for the most part, this works as expected.

However, trying to do something like:

{% extends "admin/base.html" %}
{% block bodyclass %}mymagicalbase {{ block.super }}{% endblock %}

does not work as desired, because subsequent templates [those which inherit from base_site] define the bodyclass block without calling super themselves; see ​GitHub search demonstrating the files affected; with the notable exception of app_index, which does call super.

By contrast, all of the templates which require extrastyles do call super to ensure the template hierarchy's block representation is preserved as the template author designed.

[resry]

I've submitted a pull request from my branch at ​ticket_21371.

[Keryn Knight <django@…>]

For completeness' sake, it looks like there was previously an attempt to fix a small subset of the affected templates, in #7425

[Claude Paroz]

Thanks Keryn, #7425 has been set as a duplicate.

[Julien GODIN]

Hello !
I have a ​pull request to address this ticket !

Fix+test cases

[Tim Graham]

I've reviewed the pull request and left comments for improvement. Please uncheck "Patch needs improvement" when it's updated.

[Tim Graham <timograham@…>]

In f5123c7291e855713b59e739bad0e50a1d50d3ef:

Fixed #21371 -- Added the block.super to admin bodyclass blocks.

Thanks Keryn Knight for the report.