Opened 11 years ago
Closed 11 years ago
#21324 closed Bug (fixed)
CSRF failure view not translated
| Reported by: | Claude Paroz | Owned by: | Bouke Haarsma |
|---|---|---|---|
| Component: | Internationalization | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
As noted in #21322, the CSRF "Forbidden" view is showing untranslatable content to the end user, which is not nice. We can assume the DEBUG=True part is more developer-oriented, but the text showing to users on production setups should be translated.
Attachments (1)
Change History (7)
by , 11 years ago
| Attachment: | 21324.diff added |
|---|
comment:1 by , 11 years ago
| Has patch: | set |
|---|
comment:2 by , 11 years ago
| Needs documentation: | set |
|---|---|
| Needs tests: | set |
| Patch needs improvement: | set |
| Triage Stage: | Unreviewed → Accepted |
comment:3 by , 11 years ago
| Status: | new → assigned |
|---|
comment:4 by , 11 years ago
| Owner: | removed |
|---|---|
| Status: | assigned → new |
comment:5 by , 11 years ago
| Needs tests: | unset |
|---|---|
| Owner: | set to |
| Patch needs improvement: | unset |
| Status: | new → assigned |
updated the patch and added tests: https://github.com/django/django/pull/1844
comment:6 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
I think it's a valid feature request.
A full patch should include tests, a mention in the release notes and maybe a comment in the code explaining why we're using string formatting instead of the i18n template tags (from what I understand, it's because the strings to be translated wouldn't be discovered by
makemessagesotherwise).