Opened 11 years ago

Closed 11 years ago

#21064 closed Cleanup/optimization (fixed)

The add_view and change_view code in contrib.admin.options share the same code and need to be refactored

Reported by: kamni Owned by: kamni
Component: contrib.admin Version: dev
Severity: Normal Keywords: admin
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

These should be refactored into a shared set of methods that can be unit tested and that provide one place to fix errors in the code

Change History (4)

comment:1 by Russell Keith-Magee, 11 years ago

Triage Stage: Unreviewed → Accepted

Agreed.

comment:2 by kamni, 11 years ago

Owner: changed from nobody to kamni
Status: new → assigned

comment:3 by Tim Graham, 11 years ago

Has patch: set
Patch needs improvement: set

Comments for improvement on the ​PR.

comment:4 by Tim Graham <timograham@…>, 11 years ago

Resolution: → fixed
Status: assigned → closed

In 390001ce52802a7fa1fceeabfb646e6b32911fb9:

Fixed #21064 -- Refactored common logic in ModelAdmin.add_view and change_view.

Note: See TracTickets for help on using tickets.
Back to Top