Opened 11 years ago

Closed 11 years ago

#20974 closed Cleanup/optimization (wontfix)

Adding test for mysql-specific model validation checks

Reported by: chrismedrela Owned by: ANUBHAV JOSHI
Component: Core (System checks) Version: 1.5
Severity: Normal Keywords: checks
Cc: anubhav9042@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There is some validation on model fields under MySQL backend here [1]. It checks if you do not use unique varchars longer than 255 characters. This code is not covered by any test.

I'm working at rewriting validation framework (see discussion on mailing list [2]), so please, do not work at this ticket until I finish.

[1] ​https://github.com/django/django/blob/master/django/db/backends/mysql/validation.py
[2] ​https://groups.google.com/forum/#!topic/django-developers/fEf21dtpqDE

Change History (4)

comment:1 by Tim Graham, 11 years ago

Summary: Adding test for mysql-specific checks → Adding test for mysql-specific model validation checks
Triage Stage: Unreviewed → Accepted

comment:2 by Tim Graham, 11 years ago

Easy pickings: unset

comment:3 by ANUBHAV JOSHI, 11 years ago

Cc: anubhav9042@… added
Owner: changed from nobody to ANUBHAV JOSHI
Status: new → assigned

​https://github.com/django/django/pull/2394

comment:4 by Russell Keith-Magee, 11 years ago

Component: Database layer (models, ORM) → Core (System checks)
Resolution: → wontfix
Status: assigned → closed

Implemented as part of the original commit: ​https://github.com/django/django/blob/master/tests/invalid_models_tests/test_ordinary_fields.py#L179

Note: See TracTickets for help on using tickets.
Back to Top