#20967 closed Uncategorized (invalid)
wrong grammar in the docmentation
| Reported by: | Owned by: | anonymous | |
|---|---|---|---|
| Component: | Documentation | Version: | 1.5 |
| Severity: | Normal | Keywords: | documentation |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
in the documentation pdf page 94
in the 3.2 Models and databases > Model inheritance >Multi-table inheritance
the statement "All of the fields of Place will also be available in Restaurant, although the data will reside in a different database table. So these are both possible:"
should be "All of the fields of Place will also be available in Restaurant, although the data will reside in a different database tables. So these are both possible:"
Attachments (1)
Change History (7)
comment:1 by , 11 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
by , 11 years ago
| Attachment: | 20967.diff added |
|---|
comment:3 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:4 by , 11 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → new |
comment:5 by , 11 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
Hi, and thanks for the contribution. I think, though, that the existing grammar is correct, and the change in your patch makes it incorrect. "a database tables" is wrong, since there is number disagreement between "a" (singular) and "tables" (plural).
It could be changed to say "resides in different database tables" (eliminating the "a") instead of "resides in a different database table." Either of these is grammatically correct, and really I think either one would semantically correct as well. The current singular version is describing just the Place data, and saying that that data resides in a different table from the table containing Restaurant data.
Since the current text is correct both grammatically and semantically, I don't think there's any need to make a change, so I'm closing this ticket.
Thanks again for taking the time to file a ticket and a patch!
comment:6 by , 11 years ago
a link to the branch containing the fix on github https://github.com/artmees/django/tree/ticket_20967
the patch of the solution