#20852 closed Bug (fixed)
Apostrophes after code markup render as left quote
| Reported by: | Owned by: | Dominic Rodger | |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | internet@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
In page https://docs.djangoproject.com/en/dev/ref/settings/ , there is a typo in sentence "You should do that in directories that will be found by staticfiles‘s finders": the single quotes in this sentence should be"'".
Thanks.
Change History (8)
comment:1 by , 11 years ago
| Cc: | added |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 11 years ago
| Has patch: | set |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
Actually, I can submit a pull request: https://github.com/django/django/pull/1429.
comment:3 by , 11 years ago
| Patch needs improvement: | set |
|---|
It would be nice if there were a simpler solution that didn't require entering unicode characters in the docs, but an unresolved sphinx ticket is all I could find. That said, if we go with this solution, we should fix all instances of this in one go.
comment:4 by , 11 years ago
| Summary: | Docs Typo → Apostrophes after code markup render as left quote |
|---|
comment:5 by , 11 years ago
To be clear - if I send a pull request which fixes all the instances of this in the docs using the approach in my previous pull request (which just fixes the one mentioned in the original report), will it be accepted? I'm very happy to do that, just want to make sure I'm not wasting my time here.
I'm not sure I'll be able to fix up the quotes parsing (though that approach might be worth looking at).
comment:6 by , 11 years ago
| Patch needs improvement: | unset |
|---|
Updated pull request at https://github.com/django/django/pull/1439 - I think that fixes all the instances of this.
p.s. I assume unsetting "Patch needs improvement" is the correct thing to do here, since I think I've addressed the issue with the original patch, that it was insufficiently comprehensive, do let me know if that's the wrong thing to do so I know for another time.
comment:7 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
I can't submit a pull request right now, but it's a trivial fix - just use "’" (U+2019) instead of "'" (see http://docutils.sourceforge.net/0.7/docs/ref/rst/restructuredtext.html).