Opened 12 years ago
Closed 12 years ago
#20061 closed Cleanup/optimization (fixed)
Out of date comment in contrib/humanize/tests.py
| Reported by: | Baptiste Mispelon | Owned by: | Baptiste Mispelon |
|---|---|---|---|
| Component: | contrib.humanize | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The comment for the HumanizeTests.humanize_tester reads:
# Using max below ensures we go through both lists
# However, if the lists are not equal length, this raises an exception
This was actually changed in commit 9ad005ec1c50e254dd61bbb1760c524aa01a79e2.
See https://github.com/django/django/commit/9ad005ec1c50e254dd61bbb1760c524aa01a79e2#L0L35
Change History (3)
comment:1 by , 12 years ago
| Has patch: | set |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
comment:2 by , 12 years ago
| Type: | Uncategorized → Cleanup/optimization |
|---|
comment:3 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
PR here: https://github.com/django/django/pull/909