#20048 closed Bug (fixed)
Test failures in flatpages app when custom User model is in use
| Reported by: | Russell Keith-Magee | Owned by: | matiasb |
|---|---|---|---|
| Component: | contrib.flatpages | Version: | 1.5 |
| Severity: | Release blocker | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
contrib.flatpages contains a number of tests that depend upon authenticated users. However, these tests fail if your app uses a custom User model.
These tests should be skipped if a custom User is defined.
An audit of other contrib apps should be performed for similar failures.
Change History (8)
comment:1 by , 12 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 12 years ago
comment:3 by , 12 years ago
| Has patch: | set |
|---|
comment:4 by , 12 years ago
Shouldn't the fixes in tests/forms.py (https://github.com/django/django/pull/908/files#diff-1) be part of a different ticket?
comment:5 by , 12 years ago
If that's preferred, sure. Worked this out here because there wasn't a ticket for that other test and I was fixing tests for flatpages.
Just let me know and I can add a ticket and rework the pull request.
comment:6 by , 12 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
I'm fine with the scope of this PR, and it looks good to me.
comment:7 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
Proposed pull request: https://github.com/django/django/pull/908.
Tests passing with SQLite.
Reviewing the other contrib apps, got failures for contrib.sitemaps, created #20060.