Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#19940 closed Bug (fixed)

Regression: setup_databases in test.simple.DjangoTestSuiteRunner doesn't handle aliases for 'default'

Reported by: Simon Percivall Owned by: nobody
Component: Testing framework Version: 1.5-rc-1
Severity: Normal Keywords:
Cc: timograham@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Regression caused by 17954.

If there's an alias for the 'default' db, they both get 'default' as test dependency, which causes dependency_ordered() to raise ImproperlyConfigured.

Attachments (2)

setup_databases.patch​ (2.3 KB ) - added by Simon Percivall 11 years ago.
setup_databases_head.patch​ (2.2 KB ) - added by Simon Percivall 11 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 by Simon Percivall, 12 years ago

Component: Uncategorized → Testing framework
Type: Uncategorized → Bug

comment:2 by Jacob, 12 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Tim Graham, 11 years ago

Cc: timograham@… added
Needs tests: set
Patch needs improvement: set

Patch no longer applies cleanly and needs a test.

by Simon Percivall, 11 years ago

Attachment: setup_databases.patch​ added

comment:4 by Simon Percivall, 11 years ago

New patch that applies on stable/1.5.x, and test case.

comment:5 by Tim Graham, 11 years ago

Needs tests: unset

Thanks, I'm not sure if this will be backported to 1.5.x though. Could you provide a patch against master (some code/files have been moved around there)?

by Simon Percivall, 11 years ago

Attachment: setup_databases_head.patch​ added

comment:6 by Simon Percivall, 11 years ago

I added a patch against master. I do think it'd it's a pity though if it's not applied to 1.5.x. It's an obvious regression, it's non-workaroundable, and it affects only the test framework.

comment:7 by Tim Graham <timograham@…>, 11 years ago

Resolution: → fixed
Status: new → closed

In 2cbd579efe2d646814bd6cb7aca8bd43a96f14ae:

Fixed #19940 -- Made test.runner.setup_databases properly handle aliases for default db.

Thanks simonpercivall.

comment:8 by Tim Graham <timograham@…>, 11 years ago

In d14db25feec73690b1cd52b3f8b83e3e38deb23b:

[1.6.x] Fixed #19940 -- Made test.runner.setup_databases properly handle aliases for default db.

Thanks simonpercivall.

Backport of 2cbd579efe from master.

comment:9 by Tim Graham <timograham@…>, 11 years ago

In 95aa2182b7878c1c64b1812b02caa38060ebcab4:

[1.5.x] Fixed #19940 -- Made test.runner.setup_databases properly handle aliases for defau

Thanks simonpercivall.

Backport of 2cbd579efe from master.

Note: See TracTickets for help on using tickets.
Back to Top