Some jQuery selectors in actions.js use hardcoded values instead of pulling from options.

[anonymous]

This is equivalent to first_name = "Django"; last_name = "Reinhardt"; full_name = "Django Reinhardt";

If you specified custom options like I just did, you'll discover that the interactivity breaks because those selectors stop matching.

[crccheck]

sketch of the change to be made

[crccheck]

Well, that description I provided pretty much sucks. Here's another one:

If you're using a custom change_list.html admin template, where you have markup for the actions that differs from the default, but still want to use the existing actions.js javascript, it won't work. The "Select All" question won't click and neither will the "Clear" button. In my case, I renamed the "clear" class because it conflicted with an existing class that did clear:both and the clear button stopped working. There's no reason for this to happen though, because you can tell the javascript what selectors to look for. It just so happens that those buttons ignore what you say.

Here's the branch I'm working in:

​https://github.com/crccheck/django/compare/ticket_19924

Trac doesn't have an option for it, but there's a minified version that needs to be built too, and I don't know how that's done in this project.

On a tangential note, I'd rather not be forced to put an anchor tag inside those buttons, but that's a separate issue and a separate ticket if there's interest.

[polmuz]

I reviewed the code and it looks good.

Here are the instructions to compile the javascript for django ​https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#javascript-patches

I think if you add that and you create a pull request this could be merged.

[Tim Graham <timograham@…>]

In 4523fcd60101124a307bd4026296337087b66884:

Fixed #19924 -- Fixed selectors in actions.js that did not use options.