Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#19850 closed Bug (fixed)

admin_static templatetag is not using the staticfiles' storage backend url

Reported by: duduklein@… Owned by: Jannis Leidel
Component: contrib.admin Version: 1.5-rc-1
Severity: Release blocker Keywords: staticfiles storage backend templatetag
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The admin_static templatetag checks for statifiles app and then imports the appropriate static templatetag.

The issue is that even when staticfiles contrib app is "installed", the templatetag imported is "static" while the one that uses the storage backend is "do_static". In Django 1.4, there was no "do_static" function, only "static",

​This is the commit that seems to have broken it.

Change History (5)

comment:1 by Jannis Leidel, 12 years ago

Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted

comment:2 by Jannis Leidel, 12 years ago

​https://github.com/django/django/commit/0a68a2994be17ed2669accead331881cb0be41dd#L0R37 clearly needs to call staticfiles_storage.url(path)

comment:3 by Jannis Leidel, 12 years ago

Owner: changed from nobody to Jannis Leidel
Status: new → assigned

comment:4 by Jannis Leidel <jannis@…>, 12 years ago

Resolution: → fixed
Status: assigned → closed

In c12891e8cd629cc16fc5d22e485b87ca3169df2c:

Fixed #19850 -- Use configured staticfiles storage to find the URL of a static file in the admin.

comment:5 by Jannis Leidel <jannis@…>, 12 years ago

In f96dd05542885d9839d4c79639164551e1f01563:

[1.5.X] Fixed #19850 -- Use configured staticfiles storage to find the URL of a static file in the admin.

Note: See TracTickets for help on using tickets.
Back to Top