A minor mistake?

[sunsongxp@…]

​https://docs.djangoproject.com/en/1.4/topics/signing/

In this page, which is about signing, enumerates several examples about how to use it. When it comes to that handling Exception, to be specific,

>>> value += 'm'
>>> try:
...    original = signer.unsign(value)
... except signing.BadSignature:
...    print "Tampering detected!"

I found that these lines failed, the error shows signing.BadSignature is not defined, I tested a while, and then I knew,

from django.core import signing

is required. The example miss that. I don't know if that count as a mistake. Besides, the information about previous line is so scarce in reference, do I need to check the source code?

[Aymeric Augustin]

Yes -- it's a good practice to include relevant imports in code samples.

[Tim Graham <timograham@…>]

In 537d44b1b937c6857ded0a2dc5703c61c5e980b4:

Fixed #19683 - Added a missing import in signing example.

Thanks sunsongxp@ for the report.

[Tim Graham <timograham@…>]

In f6075b0596e20951bd8232f09d97fb7fac08308c:

[1.5.x] Fixed #19683 - Added a missing import in signing example.

Thanks sunsongxp@ for the report.

Backport of 537d44b1b9 from master

[Tim Graham <timograham@…>]

In f6075b0596e20951bd8232f09d97fb7fac08308c:

[1.5.x] Fixed #19683 - Added a missing import in signing example.

Thanks sunsongxp@ for the report.

Backport of 537d44b1b9 from master