Bug in inlines.js

[rj@…]

I just noticed a small bug in inlines.js. In the part where the "addButton" is included, the following check is used:

if ($this.attr("tagName") == "TR") {

This check doesn't work as expected however. The attr-method reads an attribute. "tagName" isn't an attribute. This check should be:

if ($this.is("tr")) {

Due to this bug, the "Add another ..." link gets positioned weirdly when using a TabularInline.

[Mark Lavin]

The admin uses jQuery 1.4.2 and prior to jQuery 1.6 you could retrieve the tagName with attr. In jQuery 1.6+ you have to use prop ​http://api.jquery.com/prop/. This needs to be changed when the jQuery version is upgraded but I don't see why this would be a bug using stock jQuery in the admin.

[rj@…]

I am not very familiar with jquery. All I know is that I saw the Add Another link behave weirdly, and this change solved it. The fix I proposed is consistent with how the rest of the file checks for the tagname.

[chris cauley]

You could just break out of jQuery, then it would be version independent.

if ($this.0.tagName.toUpperCase()=="TR") {

[Bas Peschier]

Closed #19623 as a duplicate.

[Bas Peschier]

The bundled jQuery handles the attr-call correctly, and though it is not the most up-to-date code there is, it should work (checked against a stock 1.4 admin).

[Julien Phalip]

A question for the OP: could you explain exactly how to reproduce this problem?

Django's JS code solely relies on the bundled version of jQuery, so I don't see how a separate version of jQuery could cause this type of conflict.

[Claude Paroz]

Now that we have jQuery 1.9.1, attr("tagName") should be prop("tagName")

[Claude Paroz <claude@…>]

In cb5545ea2d747e2457221a03e985ef9b4a79ee2e:

Fixed #19598 -- Fixed jQuery tagName retrieving

Thanks rj at rudiculous.net for the report.