#19586 closed Bug (fixed)
URL_VALIDATOR_USER_AGENT is said to be deprecated, but has actually been removed
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
The docs (https://docs.djangoproject.com/en/dev/ref/settings/#url-validator-user-agent) say that URL_VALIDATOR_USER_AGENT has been deprecated, but it's actually been removed.
There's at least two instances where that caused trouble; it was mentioned once (https://docs.djangoproject.com/en/dev/ref/settings/#url-validator-user-agent) on the django-users mailing list. I stumbled upon it trying to setup django-oscar (http://oscarcommerce.com/), a shop solution for Django. It fails trying to import the setting.
My preferred way of fixing it would be a DeprecationMessage, but I assume due to the looming release deadline, an update to the docs is more appropriate.
Change History (5)
comment:1 by , 12 years ago
comment:2 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 by , 12 years ago
Just for completeness: The Feature was removed in 1.4 because it followed an accelerated deprecation process of only one major version instead of the usual two.
I just saw that URL_VALIDATOR_USER_AGENT was already deprecated in 1.3.1. https://docs.djangoproject.com/en/1.3/ref/settings/#url-validator-user-agent:
It still shows up in the docs for 1.4. https://docs.djangoproject.com/en/1.4/ref/settings/#url-validator-user-agent:
So, really, it should just be removed from the docs of 1.5.