LiveServerThread handles caught exceptions incorrectly

[flub@…]

In django.test.testcases.LiveServerThread.run a WSGIServerException is caught and the code expects it to have an errno attribute. However not WSGIServerException is a subclass of Exception and thus not guaranteed to have the errno attribute. The following short patch avoids this problem:

diff --git a/django/test/testcases.py b/django/test/testcases.py
index 3bb40a5..ef4c8118 100644
--- a/django/test/testcases.py
+++ b/django/test/testcases.py
@@ -1022,7 +1022,7 @@ class LiveServerThread(threading.Thread):
                         (self.host, port), QuietWSGIRequestHandler)
                 except WSGIServerException as e:
                     if (index + 1 < len(self.possible_ports) and
-                        e.args[0].errno == errno.EADDRINUSE):
+                        getattr(e.args[0], 'errno', 0) == errno.EADDRINUSE):
                         # This port is already in use, so we go on and try with
                         # the next one in the list.
                         continue

[Julien Phalip]

Thanks for the report. I've fixed the formatting – please use 'Preview' in the future.

[Julien Phalip <jphalip@…>]

In 612357f8ef729689cf52101add8c90d0528a7421:

Fixed #19355 -- Improved LiveServerThread's handling of exceptions. Thanks to flub for the report.

[Julien Phalip <jphalip@…>]

In 2e5b725197db406aa8b94aa4a86e2bac3dc571b1:

[1.5.x] Fixed #19355 -- Improved LiveServerThread's handling of exceptions. Thanks to flub for the report.
Backport of 612357f8ef