Collect static copies a .py file

[Camilo Nova]

When you run a collectstatic the file compress.py gets copied to the static directory, and that doesn't seem right.

I have created a pull request because this was generating PEP8 warnings for a project, but looking at the comments i agree this file shouldn't be copied.

​https://github.com/django/django/pull/474

Maybe some can tweak the collectstatic command so it ignores .py files.

[Aymeric Augustin]

Yes, this file isn't designed to be served, it should be moved outside of the admin's static directory.

[Jannis Leidel]

Or we could add .py to the list of ignore file extensions.

[Camilo Nova]

Ignoring the .py file extensions sounds a better idea overall

[Aymeric Augustin]

My personal website offers some Python scripts for download. I'm currently storing them as static files. If .py files were ignored by collectstatic they wouldn't be served anymore.

I may be abusing the static files framework :) but it's possible that other people are doing the same thing. For this reason, "ignore .py files" wasn't my first choice, but I would understand it.

[Russell Keith-Magee]

Can anyone explain why the compress.py file is actually in the static directory to start with? If the static directory is the directory of stuff you want to share, It seems to me that we could avoid this whole problem by putting compress.py somewhere else (like a utilities directory -- which is what compress.py is anyway)

[Ramiro Morales]

Opinions on proposed fix: ​https://github.com/ramiro/django/compare/19333-move-compress.py are welcome.

[Camilo Nova]

Ramiro, looks good and clean. Thanks

[Aymeric Augustin]

After your changes the script works only if you pass file names in argument or if you run it from django/contrib/admin/static/admin/js.

The here variable should be called admin_js_dir, because that's what it really is :)

I suggest renaming that variable and pointing it to os.path.join(os.path.dirname(os.path.dirname(__file__)), 'static', 'admin', 'js') (to be tested, I just wrote it in this comment as an example).

Otherwise, that's the correct fix IMO.

[Ramiro Morales]

Replying to aaugustin:

After your changes the script works only if you pass file names in argument or if you run it from django/contrib/admin/static/admin/js.

According to my understanding of the code it's also the current behavior. No changes here.

The here variable should be called admin_js_dir, because that's what it really is :)

If I'm right above, the meaning of this var hasn't changed either. It is the CWD from which the script is being executed (not the dir where the script is located).

I suggest renaming that variable and pointing it to os.path.join(os.path.dirname(os.path.dirname(__file__)), 'static', 'admin', 'js') (to be tested, I just wrote it in this comment as an example).

Otherwise, that's the correct fix IMO.

The only change this patch introduces is that to ejecute compress.py one needs to specify its full path (e.g. python ../../../bin/compress.py). Remember the intended potential uses of this script are core devs and people contributing with the admin app by submitting JS patches.

[Julien Phalip]

I think the patch looks great. The only thing left to update is the doc: ​https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#compressing-javascript

[Julien Phalip]

Never mind, I got a little confused. The patch already modifies the doc...

On second thought, I agree with Aymeric in comment:8 to not use getcwd(), so that the command can be run from anywhere.

[Julien Phalip]

Here's the suggested patch: ​https://github.com/jphalip/django/commit/62ea2101b6012244aeb502b1435e180c7b97bd94

[Julien Phalip <jphalip@…>]

In c9c40bc6bc64e67365338751e4967d86d0882abf:

Fixed #19333 -- Moved compress.py outside of the admin static folder. Thanks to camilonova, Russell Keith-Magee, Aymeric Augustin and Ramiro Morales for the feedback.

[Julien Phalip <jphalip@…>]

In be5369fd24adfc788e59eaf0363d4d137ded6ef8:

[1.5.x] Fixed #19333 -- Moved compress.py outside of the admin static folder. Thanks to camilonova, Russell Keith-Magee, Aymeric Augustin and Ramiro Morales for the feedback.
Backport of c9c40bc6bc64e6

[Julien Phalip <jphalip@…>]

In be5369fd24adfc788e59eaf0363d4d137ded6ef8:

[1.5.x] Fixed #19333 -- Moved compress.py outside of the admin static folder. Thanks to camilonova, Russell Keith-Magee, Aymeric Augustin and Ramiro Morales for the feedback.
Backport of c9c40bc6bc64e6