qs.values().delete() doesn't work consistently

[Anssi Kääriäinen]

If you do SomeModel.objects.values().delete() you will get a stack trace like this one:

  File "/home/akaariai/Programming/django/tests/django/db/models/query.py", line 525, in delete
    collector.collect(del_query)
  File "/home/akaariai/Programming/django/tests/django/db/models/deletion.py", line 195, in collect
    reverse_dependency=reverse_dependency)
  File "/home/akaariai/Programming/django/tests/django/db/models/deletion.py", line 105, in add
    if obj not in instances:
  TypeError: unhashable type: 'dict'

However if the "fast-path" deletion route is taken, then the deletion will work.

I think we should make values().delete() and values_list().delete() throw an error explicitly. We might later on want to make values().delete() work, or have special meaning for such queries (see #9519 for example). But for now making sure that this errors consistently seems like a good idea.

[Anssi Kääriäinen]

Implemented in ​https://github.com/akaariai/django/commit/8e99c93bb650a5a87fb811c1b0632469fd3ca82e

[Anssi Kääriäinen <akaariai@…>]

In 7de439f32d5da88f8a5717717a9e152441708a9f:

Fixed #19187 -- Raise consistent error from qs.values().delete()