Opened 12 years ago
Closed 12 years ago
#18991 closed New feature (fixed)
Allow the use of 'app_name.perm_name' in perms in templates
Reported by: | Anssi Kääriäinen | Owned by: | nobody |
---|---|---|---|
Component: | Template system | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Now that we have smart if tag, it seems natural to look up permissions by
{% if 'someapp.someperm' in perms %} Permission found! {% endif %}
In addition to feeling more natural to me, this has two additional benefits:
- If is possible to look up permissions containing characters which aren't allowed by template variable resoultion: if perms.someapp.some-perm doesn't work for example.
- The exact same syntax is likely to work in other template engines, too (think Jinja2).
I have implemented this in https://github.com/akaariai/django/compare/perm_in_perms
I hope to push this into 1.5.
Change History (3)
comment:1 by , 12 years ago
comment:2 by , 12 years ago
A pull created: https://github.com/django/django/pull/404
BTW, there is another benefit of the alternate syntax: permission lookups using variables.
There isn't support for perm_obj in perms, only the string syntax is supported. Using Permission objects directly would be a natural extensions to this feature...
comment:3 by , 12 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
I forgot to mention that the above branch contains the fix for #18979, too. So, that is the !EQLimiterObject stuff in the patch...