Opened 12 years ago
Closed 12 years ago
#18965 closed Cleanup/optimization (wontfix)
Properly deprecate PROFANITIES_LIST.
| Reported by: | Tom Christie | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.comments | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | tom@… | Triage Stage: | Accepted |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Okay, so it's been set to an empty tuple now, tho I *believe* that formally removing it has been mentioned at a couple of DjangoCon talks this year, although I could be mistaken.
Closest thing I can find online is this gist of Adrian's keynote which mentions it (without context) - https://gist.github.com/3643761
If this gets the thumbs up I'll make the required pull request.
Change History (5)
comment:1 by , 12 years ago
| Cc: | added |
|---|
comment:2 by , 12 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|---|
| Type: | Uncategorized → Cleanup/optimization |
comment:3 by , 12 years ago
Adrian also mentioned removing django.contrib.comments entirely. That may be the way to go rather than doing the extra work of deprecating the settings for an app that's ultimately going to be removed.
comment:4 by , 12 years ago
That sounds sane. Is there an outstanding ticket or similar for that?
Any idea what the plan would be given the dependancy on it from admin?
comment:5 by , 12 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
django.contrib.comments has been deprecated and is no longer supported, so I'm closing this ticket. We're encouraging users to transition to a custom solution, or to a hosted solution like Disqus.
The code itself has moved to https://github.com/django/django-contrib-comments; if you want to keep using it, you could move this bug over there.
I do recall this being mentioned as a goal. I'm sure patches would be welcome.